Skip to content

test: Async safe log write to console #5094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 22, 2025
Merged

test: Async safe log write to console #5094

merged 4 commits into from
Apr 22, 2025

Conversation

philipphofmann
Copy link
Member

Ensure setting SENTRY_ASYNC_SAFE_LOG_ALSO_WRITE_TO_CONSOLE = 1 doesn't get committed by accident.

#skip-changelog

@philipphofmann
test: Async safe log write to console
f74e160 
Ensure setting SENTRY_ASYNC_SAFE_LOG_ALSO_WRITE_TO_CONSOLE = 1
doesn't get committed by accident.
@philipphofmann philipphofmann mentioned this pull request Apr 15, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.689%. Comparing base (8bd2b82) to head (b6e222b).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5094       +/-   ##
=============================================
- Coverage   92.787%   92.689%   -0.099%     
=============================================
  Files          676       676               
  Lines        83881     83876        -5     
  Branches     30537     29453     -1084     
=============================================
- Hits         77831     77744       -87     
- Misses        5952      6037       +85     
+ Partials        98        95        -3

see 23 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd2b82...b6e222b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@philprime
Copy link
Contributor

m: While I do like this approach in using tests to cause the failure of CI, where else is this SENTRY_ASYNC_SAFE_LOG_ALSO_WRITE_TO_CONSOLE used and where else can it become a problem?
What if it is not set on SentryTests but set on Sentry?

I believe I need more context here.

@philipphofmann
Copy link
Member Author

I did this as a follow up on: #5091 (comment). I added a clarification comment. Is it clearer now @philprime?

philprime
philprime approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to block this PR longer therefore LGTM approved, but I want to point out that it's not clear where the flag needs to be set, therefore I don't know how to test this.

@philipphofmann
Copy link
Member Author

Thanks for the feedback, @philprime . Is it clear now b6e222b?

@philprime
Copy link
Contributor

Makes sense now, thank you!

@philipphofmann philipphofmann merged commit da7b357 into main Apr 22, 2025
69 of 72 checks passed
@philipphofmann philipphofmann deleted the test/async-safe-log branch April 22, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philprime philprime philprime approved these changes

@armcknight armcknight Awaiting requested review from armcknight armcknight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipphofmann @philprime